Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs/deployment/docker-swarm] precision about ipv6 #241

Closed
wants to merge 1 commit into from

Conversation

arthurzenika
Copy link

@arthurzenika arthurzenika commented Oct 13, 2020

Description

Improve the doc about docker-swarm deployment

Motivation and Context

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

@derek
Copy link

derek bot commented Oct 13, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Oct 13, 2020
@derek derek bot closed this Oct 13, 2020
@derek
Copy link

derek bot commented Oct 13, 2020

Thank you for your interest in this project, but unfortunately your commit did not follow the contributing guidelines.

Check the following:

See also Hacktoberfest quality standards

@derek derek bot added the invalid This doesn't seem right label Oct 13, 2020
@arthurzenika
Copy link
Author

Related to #242

@arthurzenika
Copy link
Author

@derek Can you tell me how to re-open this pull request ? Can I suggest a shorter CONTRIBUTING document for docs ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant