Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #337

Merged
merged 12 commits into from
Aug 9, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jun 9, 2023

Ticket

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17 along with testing-library/react & react-test-renderer to respective compatible versions
  • Since Enzyme does not provide support React 17 (enzymejs/enzyme#2429) or 18 (enzymejs/enzyme#2524) itself we switched to community-supported project that aim to provide compatibility between Enzyme and React 17, replacing enzyme-adapter-react-16 with @wojtekmaj/enzyme-adapter-react-17
  • Updated edx packages @edx/frontend-platform, @edx/frontend-component-header, @edx/frontend-component-footer

Developer Checklist

  • Test suites passing
  • Documentation and test plan updated, if applicable
  • Received code-owner approving review
  • Bumped version number package.json

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (44197f6) 94.93% compared to head (7f2b685) 94.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         139      139           
  Lines        1343     1343           
  Branches      264      264           
=======================================
  Hits         1275     1275           
  Misses         60       60           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m marked this pull request as ready for review July 5, 2023 11:04
@Mashal-m Mashal-m requested a review from a team as a code owner July 5, 2023 11:04
@Mashal-m Mashal-m force-pushed the bilalqamar95/react-upgrade-to-v17 branch from 5d79359 to b3d5e06 Compare July 12, 2023 13:52
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@BilalQamar95 BilalQamar95 merged commit 5e96dbf into master Aug 9, 2023
@BilalQamar95 BilalQamar95 deleted the bilalqamar95/react-upgrade-to-v17 branch August 9, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants