-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update react & react-dom to v17 #337
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 139 139
Lines 1343 1343
Branches 264 264
=======================================
Hits 1275 1275
Misses 60 60
Partials 8 8 ☔ View full report in Codecov by Sentry. |
…ilalqamar95/react-upgrade-to-v17
Mashal-m
force-pushed
the
bilalqamar95/react-upgrade-to-v17
branch
from
July 12, 2023 13:52
5d79359
to
b3d5e06
Compare
…ontend-app-gradebook into bilalqamar95/react-upgrade-to-v17
…ilalqamar95/react-upgrade-to-v17
mattcarter
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade React JS to v17
Description
react
&react-dom
to v17 along withtesting-library/react
&react-test-renderer
to respective compatible versionsenzyme-adapter-react-16
with@wojtekmaj/enzyme-adapter-react-17
@edx/frontend-platform, @edx/frontend-component-header, @edx/frontend-component-footer
Developer Checklist
Testing Instructions
[ How should a reviewer test this PR? ]
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora