Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New Fact about Largest Pizza Festivale #66

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

MrAshwin2142
Copy link
Contributor

@MrAshwin2142 MrAshwin2142 commented Nov 24, 2023

Description

This PR adds a new pizza fact about Largest Pizza Festivale to the list.

What type of PR is this? (check all applicable)

  • ☝️ Add a pizza fact or trivia
  • 🧑‍🍳 Add a pizza recipe
  • 🗺️ Add a regional pizza
  • 📝 Documentation Update

Related Tickets & Documents

Relates to #36

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

What GIF best describes this PR or how it makes you feel?

download

@CBID2
Copy link
Contributor

CBID2 commented Nov 24, 2023

Hi @MrAshwin2142. Can you fill out the Related Tickets and Documents and Description sections of your PR form? Also, can you give a more descriptive title as opposed to "add a new pizza fact"? It'll add more context to your contribution. Here's an example: #49

If you need more help with this, check out this article: https://dev.to/opensauced/tip-for-getting-your-pull-request-reviewed-on-github-2b7c

@MrAshwin2142 MrAshwin2142 changed the title New Pizza Fact Added Added New Fact about Largest Pizza Festivale Dec 1, 2023
@CBID2
Copy link
Contributor

CBID2 commented Dec 12, 2023

Hey @MrAshwin2142. Are you still work on this?

@CBID2
Copy link
Contributor

CBID2 commented Dec 13, 2023

Why did you close this PR @MrAshwin2142?

@MrAshwin2142
Copy link
Contributor Author

sorry , but i am confused.

@CBID2
Copy link
Contributor

CBID2 commented Dec 13, 2023

sorry , but i am confused.

What are you confused about @MrAshwin2142?

@MrAshwin2142
Copy link
Contributor Author

What specific changes do I have to make?

@CBID2
Copy link
Contributor

CBID2 commented Dec 13, 2023

What specific changes do I have to make?

Hi @MrAshwin2142. As I mentioned here, you need to add a description of your contribution to the Description section of your PR form. You also need to link the issue that it addresses in the Related Documents section of the form. It's done like this:

Relates to #issue number

Making these changes will easier for me to review your contribution as it provides more context.

@CBID2 CBID2 reopened this Dec 13, 2023
@MrAshwin2142
Copy link
Contributor Author

@CBID2 thank you for clarification, informatio updated.

Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @MrAshwin2142!

@CBID2 CBID2 merged commit a05f82d into open-sauced:main Dec 13, 2023
@CBID2 CBID2 added the good first issue Good for newcomers label Jan 25, 2024
@CBID2 CBID2 linked an issue Jan 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pizza fact or trivia (Please Keep Open)
2 participants