Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a pizza fact #46

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Added a pizza fact #46

merged 5 commits into from
Oct 24, 2023

Conversation

david-001
Copy link
Contributor

@david-001 david-001 commented Oct 20, 2023

Description

Added a pizza fact in the pizza-facts-&-trivia.md

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Relates to #36

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your Pull Request @david-001! We've merged in some new PRs since you submitted. Can you merge the latest changes and resolve conflicts? If you need some help with that, check out this post: Keeping Your Branch Up to Date and Handling Merge Conflicts While Waiting for PR Reviews. Also, can you fill out the description and other sections of your PR's form? It'll make it easier for me and other maintainers to review your contribution. Check out the blog post, Writing Your First Pull Request: Tips, Best Practices, and AI-Powered Tools for Success to learn how.

@david-001
Copy link
Contributor Author

I merged the latest changes and resolved the conflicts. Can you specify which sections of my PR form I need to fill out? The sections I left out are either not relevant or optional. Thanks.

@CBID2
Copy link
Contributor

CBID2 commented Oct 21, 2023

I merged the latest changes and resolved the conflicts. Can you specify which sections of my PR form I need to fill out? The sections I left out are either not relevant or optional. Thanks.

Fill out the Description section. In there,briefly describe the fact you add to the file.

@david-001
Copy link
Contributor Author

Sorry about that. I filled out the Description.

pizza-facts-&-trivia.md Outdated Show resolved Hide resolved
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @david-001. Your entry is off to a great start. Just found a typo that needs fixing.

Thanks for the correction!

Co-authored-by: Christine Belzie <[email protected]>
@david-001
Copy link
Contributor Author

I committed your correction. Thanks!

pizza-facts-&amp;-trivia.md Outdated Show resolved Hide resolved
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're close @david-001. Just need to make a few more adjustments.

@david-001
Copy link
Contributor Author

I think I resolved the conflict this time.

Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@CBID2 CBID2 merged commit b58b383 into open-sauced:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants