Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix my profile broken link #572

Merged
merged 13 commits into from
Dec 18, 2024
Merged

docs: Fix my profile broken link #572

merged 13 commits into from
Dec 18, 2024

Conversation

nhim-uit
Copy link
Contributor

@nhim-uit nhim-uit commented Nov 13, 2024

Description

This PR fix #571

What type of PR is this? (check all applicable)

  • 🤝 Add a contributor
  • 📝 Documentation Update

Related Issues

Closes #571

Contributors Checklist

I've read through the Getting Started section

  • ✅ Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • ✅ Yes
  • ❌ No

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Screenshot (Required for PR Review)

new contributor

[optional] What GIF best describes this PR or how it makes you feel?

gif

@nhim-uit nhim-uit requested a review from a team as a code owner November 13, 2024 10:03
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@nhim-uit nhim-uit changed the title Fix my profile broken link docs: Fix my profile broken link Nov 13, 2024
@adiati98
Copy link
Member

Hey @nhim-uit,

I see that you change things manually here.
Based on how the app works, I'm not sure you can add profile link outside GitHub without breaking things.

@BekahHW can you confirm this?

If you've changed your username on GitHub and want to use it, what I can suggest is for you to close this PR and create a new one.

@adiati98 adiati98 self-requested a review December 18, 2024 11:29
@adiati98 adiati98 merged commit 20398bb into open-sauced:main Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: fix broken link of @nhim-uit
3 participants