Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add @Emmarie-Ahtunan as a contributor #147

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

Emmarie-Ahtunan
Copy link
Contributor

@Emmarie-Ahtunan Emmarie-Ahtunan commented Oct 21, 2023

Description

This PR adds me as a contributor to the guestbook.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@CBID2 CBID2 requested a review from adiati98 October 22, 2023 06:24
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Emmarie-Ahtunan
Thank you for your PR!

But you missed the step to run the npm run contributors:generate to update the README.
Please see step no. 6 the Getting Started section.

@Emmarie-Ahtunan Emmarie-Ahtunan marked this pull request as draft October 22, 2023 07:04
@Emmarie-Ahtunan Emmarie-Ahtunan changed the title feat: add {GitHub username} as a contributor docs: add {GitHub username} as a contributor Oct 22, 2023
@adiati98
Copy link
Member

@Emmarie-Ahtunan
We have merged a PR before yours. So while you're making changes, please also resolve the conflicts before we can merge yours.

Please let us know if you need any help :)

@Emmarie-Ahtunan
Copy link
Contributor Author

Hello @adiati98 I tried running the npm run contributors:generate again this morning and it's deleting a lot of the README.md file. I'm not sure what to do, can you help please?

@adiati98
Copy link
Member

adiati98 commented Oct 22, 2023

Hi @Emmarie-Ahtunan,
You've closed this PR so I can't see the changes you made πŸ˜…
But I had the chance to see that all of the generated profiles were deleted on README.

Running npm run contributors:generate should not delete them and instead, updating them. So I'm also not sure what's going on here.

So I see you force-pushed your branch.
Can you let me know the current state there?

@adiati98
Copy link
Member

Let me reopen this PR so I can walk you through, @Emmarie-Ahtunan :)

@adiati98 adiati98 reopened this Oct 22, 2023
@Emmarie-Ahtunan
Copy link
Contributor Author

I just fixed it and added a new PR that I think works.

@adiati98
Copy link
Member

Awesome, @Emmarie-Ahtunan!
Can you revert this draft to ready for review?

@Emmarie-Ahtunan
Copy link
Contributor Author

I synced my fork to not have a merge conflict. So these files are deleted. May I see if I can comment on my current "conflicting" PR?

@adiati98
Copy link
Member

adiati98 commented Oct 22, 2023

I synced my fork to not have a merge conflict. So these files are deleted. May I see if I can comment on my current "conflicting" PR?

Sorry, I don't catch you. Which files are deleted? I mean, I see both files here.
You just need to convert this draft back to a PR :)

@Emmarie-Ahtunan Emmarie-Ahtunan marked this pull request as ready for review October 22, 2023 08:08
@Emmarie-Ahtunan
Copy link
Contributor Author

I just did, with the updated changes. I apologize and also thank you so very much @adiati98!

@adiati98 adiati98 changed the title docs: add {GitHub username} as a contributor docs: add @Emmarie-Ahtunan as a contributor Oct 22, 2023
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! Well done, @Emmarie-Ahtunan! πŸ™Œ

I see that you have contributed to our pizza-verse repo! Thank you for your contributionsπŸ˜„
If you haven't, you can join our community Discord 😊

@adiati98 adiati98 merged commit 1f5c679 into open-sauced:main Oct 22, 2023
@adiati98
Copy link
Member

I just did, with the updated changes. I apologize and also thank you so very much @adiati98!

No need to apologize, @Emmarie-Ahtunan! πŸ˜„

Did you use our docs to resolve conflicts?
If so, may I ask for your feedback if they're clear enough?
TIA! 😊

@Emmarie-Ahtunan
Copy link
Contributor Author

Yay! I'm so very excited ... thank you so much @adiati98! Yes, I've joined the Discord already and I have some more changes to make to the pizza-verse contribution before it can be merged but this one is golden; tysvm!

@Emmarie-Ahtunan
Copy link
Contributor Author

I just did, with the updated changes. I apologize and also thank you so very much @adiati98!

No need to apologize, @Emmarie-Ahtunan! πŸ˜„

Did you use our docs to resolve conflicts? If so, may I ask for your feedback if they're clear enough? TIA! 😊

Your docs are clear enough, yes. I read them, especially for the PR request documentation on my pizza-verse PRs but I still don't understand what I need to change for that. Open-sauced is AMAZING!!!

@adiati98
Copy link
Member

I just did, with the updated changes. I apologize and also thank you so very much @adiati98!

No need to apologize, @Emmarie-Ahtunan! πŸ˜„
Did you use our docs to resolve conflicts? If so, may I ask for your feedback if they're clear enough? TIA! 😊

Your docs are clear enough, yes. I read them, especially for the PR request documentation on my pizza-verse PRs but I still don't understand what I need to change for that. Open-sauced is AMAZING!!!

Thank you so much for your feedback, @Emmarie-Ahtunan! πŸ’™
We hope we see you around for another contributions! πŸ™Œ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants