-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add @Emmarie-Ahtunan as a contributor #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Emmarie-Ahtunan
Thank you for your PR!
But you missed the step to run the npm run contributors:generate
to update the README.
Please see step no. 6 the Getting Started section.
@Emmarie-Ahtunan Please let us know if you need any help :) |
Hello @adiati98 I tried running the npm run contributors:generate again this morning and it's deleting a lot of the README.md file. I'm not sure what to do, can you help please? |
1b55001
to
474f828
Compare
Hi @Emmarie-Ahtunan, Running So I see you force-pushed your branch. |
Let me reopen this PR so I can walk you through, @Emmarie-Ahtunan :) |
I just fixed it and added a new PR that I think works. |
Awesome, @Emmarie-Ahtunan! |
I synced my fork to not have a merge conflict. So these files are deleted. May I see if I can comment on my current "conflicting" PR? |
Sorry, I don't catch you. Which files are deleted? I mean, I see both files here. |
I just did, with the updated changes. I apologize and also thank you so very much @adiati98! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good! Well done, @Emmarie-Ahtunan! π
I see that you have contributed to our pizza-verse
repo! Thank you for your contributionsπ
If you haven't, you can join our community Discord π
No need to apologize, @Emmarie-Ahtunan! π Did you use our docs to resolve conflicts? |
Yay! I'm so very excited ... thank you so much @adiati98! Yes, I've joined the Discord already and I have some more changes to make to the pizza-verse contribution before it can be merged but this one is golden; tysvm! |
Your docs are clear enough, yes. I read them, especially for the PR request documentation on my pizza-verse PRs but I still don't understand what I need to change for that. Open-sauced is AMAZING!!! |
Thank you so much for your feedback, @Emmarie-Ahtunan! π |
Description
This PR adds me as a contributor to the guestbook.
What type of PR is this? (check all applicable)
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?