fix: improve accessibility in CardHorizontalBarChart and InfoTooltip … #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammedfirdouss
requested review from
brandonroberts,
nickytonline and
zeucapua
as code owners
👷 Deploy request for oss-insights pending review.Visit the deploys page to approve it
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Watched Files
This pull request modifies specific files that require careful review by the maintainers.
Files Matched
- npm-shrinkwrap.json
- package.json
❌ Deploy Preview for design-insights failed. Why did it fail? →
|
|
@nickytonline Here is the updated PR with the requested adjustments and fewer changes as discussed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes accessibility issues in the CardHorizontalBarChart and InfoTooltip components. It addresses the
jsx-a11y/mouse-events-have-key-eventswarnings and improves keyboard navigation support.Related Tickets & Documents
Fixes #4133
Mobile & Desktop Screenshots/Recordings
N/A (No visual changes, only accessibility improvements)
Steps to QA
Testing
CardHorizontalBarChartAccessibilityCheck Screen Reader Compatibility:
sr-onlyspan for screen reader descriptions.Keyboard Navigation:
Tabto focus on each language bar and ensure it announces the language and percentage information.Testing
InfoTooltipAccessibilityTier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?