Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Reform multiviewpose #1853

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[Enhance] Reform multiviewpose #1853

wants to merge 10 commits into from

Conversation

wusize
Copy link
Collaborator

@wusize wusize commented Dec 2, 2022

Motivation

Reformulate "DetectAndRegress" so that it has similar structure with a bottom-up method

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


wusize seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@wusize wusize requested a review from jin-s13 December 2, 2022 06:13
Copy link
Collaborator

@jin-s13 jin-s13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to retrain models and replace the original ckpts.

@ly015 ly015 changed the title Reform multiviewpose [Enhance] Reform multiviewpose Dec 2, 2022
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 84.03% // Head: 83.98% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (07ead74) compared to base (1f11d6c).
Patch coverage: 19.04% of modified lines in pull request are covered.

❗ Current head 07ead74 differs from pull request most recent head 851d74a. Consider uploading reports for the commit 851d74a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1853      +/-   ##
==========================================
- Coverage   84.03%   83.98%   -0.05%     
==========================================
  Files         241      241              
  Lines       20869    20879      +10     
  Branches     3609     3612       +3     
==========================================
- Hits        17537    17535       -2     
- Misses       2406     2414       +8     
- Partials      926      930       +4     
Flag Coverage Δ
unittests 83.91% <19.04%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/models/detectors/multiview_pose.py 68.12% <15.00%> (-1.45%) ⬇️
mmpose/datasets/pipelines/top_down_transform.py 76.38% <100.00%> (ø)
mmpose/models/utils/misc.py 71.42% <0.00%> (-28.58%) ⬇️
mmpose/datasets/pipelines/shared_transform.py 81.53% <0.00%> (-0.91%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jin-s13 jin-s13 changed the base branch from master to dev-0.29 January 18, 2023 14:25
@jin-s13 jin-s13 changed the base branch from dev-0.29 to master January 18, 2023 14:25
@wusize wusize force-pushed the reform_multiviewpose branch from 07ead74 to 851d74a Compare February 15, 2023 03:43
@wusize wusize force-pushed the reform_multiviewpose branch from 69b0fff to 528d4dc Compare March 15, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants