Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CG-Bench dataset support #669

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lyccnb
Copy link

@lyccnb lyccnb commented Dec 16, 2024

Commit cg-bench:
In addition to creating the necessary files (vlmeval/dataset/cgbench.py, vlmeval/dataset/utils/cgbench.py) and modifying vlm/dataset/init.py, the following changes were implemented:

  1. In run.py:

    • Added parameters to accommodate cg-bench's requirements: use_subtitle_time and use_frame_time
    • Combined these with the existing use_subtitle parameter to construct new dataset_kwargs for cg-bench
    • These parameters are passed to the dataset implementation
  2. Modified file naming conventions to reflect parameter usage:

    • Updated the template string for intermediate result files to include subtitle status, subtitle timing, and frame timing information
    • Modified the naming pattern: tmpl = tmpl.replace('.pkl', f'_{subtitle_str}_{subtitle_time_str}_{frame_time_str}.pkl')
    • Made corresponding changes in vlmeval/inference_video to maintain consistency
  3. Updated model configuration:

    • Added model specification for open-ended dataset evaluation: judge_kwargs['model'] = 'gpt-4o-0806' in run.py
    • This ensures compatibility with cg-bench evaluation requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant