Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct main entry for relative path #136

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

milaninfy
Copy link
Contributor

@milaninfy milaninfy commented Dec 9, 2024

npm-packlist gets normalized package-json when assessing files to include. when main is specified with relative file path it doesn't consider that entry when including files. Fixing main in normalization step

  • check on changes condition
  • sanity testing
  • check npm pack command with empty files array in package.json
    • arborist node uses read-package-json-fast normalization functionality instead of package-json's normalization flow
  • need to check for read-package-json-fast's normalization logic to replace it with package-json's normalization

Fixes: npm/cli#7799

@milaninfy milaninfy force-pushed the mm/fix-relative-main branch from b9f766d to 92f7aee Compare December 11, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] npm pack doesn't include file specified in main field
1 participant