Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: request token for amaro #933

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marco-ippolito
Copy link
Member

Should fix: nodejs/amaro#101

permissions:
  contents: write
  pull-requests: write

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the token name and date are filled in.

@legendecas
Copy link
Member

@marco-ippolito could you name the token?

@marco-ippolito
Copy link
Member Author

Does AMARO_SWC_UPDATE_TOKEN sound good?

@legendecas
Copy link
Member

yeah, sounds good. TBH it's up to the owner of the repo.

@legendecas
Copy link
Member

if it will be used in release-please as well, probably name it as like GH_USER_TOKEN.

@marco-ippolito marco-ippolito force-pushed the request-token-for-amaro branch from 5f72b12 to f3ab40d Compare December 10, 2024 14:13
@marco-ippolito marco-ippolito force-pushed the request-token-for-amaro branch from f3ab40d to 238939c Compare December 10, 2024 14:13
@marco-ippolito
Copy link
Member Author

@legendecas I used same name as other ones since it will be used in release plz in the future, set expiration day as if it is created tomorrow. Can I create it myself?

@legendecas
Copy link
Member

legendecas commented Dec 10, 2024

if you have access to @nodejs-github-bot account please feel feel to go ahead. Or maybe @mhdawson could help with this

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Dec 16, 2024

@legendecas I apparently don't have access 😢

@legendecas
Copy link
Member

legendecas commented Dec 16, 2024

I don't have access either (mhdawson is on vacation). It'd be great to update this process with #936, which allow TSC members to grant new access without @nodejs-github-bot's password.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SWC update does not trigger CI
4 participants