Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Skip folders which contain a .nomedia or .noimage file #699

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

schklom
Copy link

@schklom schklom commented Mar 16, 2022

@tacruc Follow-up on #617

@schklom
Copy link
Author

schklom commented Mar 17, 2022

@tacruc DCO is still unhappy, and wants me to do the same commands as in #617:

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~2 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin master

This should lead (again) to a large volume of commits as in the previous PR. What should I do?

@tacruc
Copy link
Collaborator

tacruc commented Mar 17, 2022

On top it explains how to commit changes, such that the commit is sign.

There is one commit incorrectly signed off. This means that the author of this commit failed to include a Signed-off-by line in the commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name [email protected] in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.

@schklom
Copy link
Author

schklom commented Mar 17, 2022

Ok i'll try again. But this is really strange because I did the pull request using github.com from the browser, I didn't expect github.com would cause problems.

@tacruc
Copy link
Collaborator

tacruc commented Mar 23, 2022

Actually I think this PR won't do what you would expect.
It will only exclude images during the inital scan. As soon files within excluded folders are uploaded or changed, they will appear.

@tacruc tacruc changed the title Skip folders which contain a .nomedia or .noimage file [Draft] Skip folders which contain a .nomedia or .noimage file Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants