[WIP] Use function name for decorators #335
Conversation
| @@ -8,7 +8,7 @@ deps= | |||
| pytest | |||
| pytest-xdist | |||
| pyuv: pyuv | |||
| commands=python -m pytest -s | |||
| commands=python -m pytest -s {posargs} | |||
There was a problem hiding this comment.
I'm adding this so I can do tox -e py36 test/test_decorators.py
| 'sync': rpc_sync, | ||
| 'opts': opts | ||
| } | ||
| return f | ||
| return dec | ||
|
|
||
|
|
||
| def capitalize_name(name): |
There was a problem hiding this comment.
I do not like this kind of magic. For plugins that use this, it would be better to break python conventions and name the implementation function literally what the vimL side name is. Also, _ is not forbidden in vimL.
There was a problem hiding this comment.
Well, a matter of style I think. I would no like to have a function/command named My_function_something, and you can still pass a name if people want that name.
There was a problem hiding this comment.
Referential transparency is more important than style. If an rplugin defines MySpecialCommand to users, I would expect to find that name literally in the source, much more often than not.
| 'sync': rpc_sync, | ||
| 'opts': opts | ||
| } | ||
| return f | ||
| return dec | ||
|
|
||
|
|
||
| def autocmd(name, pattern='*', sync=False, allow_nested=False, eval=None): | ||
| def autocmd(name=None, pattern='*', sync=False, allow_nested=False, eval=None): |
There was a problem hiding this comment.
It can be a concern that a plugin potentially can have multiple implementations of the autocmd with disjoint patterns. At least there should be a warning in the docs. (python doesn't give a warning on method shadowing, though we could hack it with a metaclass).
There was a problem hiding this comment.
I wasn't sure about the autocmd, it doesn't have much sense here I guess.
There was a problem hiding this comment.
Maybe the parameter should be named event, that's why I was confused here.
|
neovim/neovim#27949 will greatly simplify the implementation and interface of remote plugins, and will remove the need for decorators (which are just sugar to do things that can/should be done in the plain Lua part of a remote plugin). |
Sometimes is kind of redundant to write the function/command/autocmd name on each decorator. Also, this can help with cases like #334.
Please, let me know if you want this feature so, I can continue :), thanks
What is missing?