Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(editor): Update workflow actions tests for the new canvas (no-changelog) #12245

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented Dec 16, 2024

Summary

  • Updating 7-workflow-actions.cy.ts to work with new canvas
  • Preventing saving already saved workflows on the new canvas

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Dec 16, 2024
@MiloradFilipovic MiloradFilipovic changed the title test(editor): Update workflow actions tests for the new canvas test(editor): Update workflow actions tests for the new canvas (no-changelog) Dec 16, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

alexgrozav
alexgrozav previously approved these changes Dec 16, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Dec 16, 2024

n8n    Run #8361

Run Properties:  status check failed Failed #8361  •  git commit 301db0af32: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project n8n
Branch Review workflow-actions-canvas-v2-e2e
Run status status check failed Failed #8361
Run duration 04m 12s
Commit git commit 301db0af32: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Committer Milorad FIlipović
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 276
View all changes introduced in this branch ↗︎

Tests for review

Failed  14-mapping.cy.ts • 1 failed test

View Output Video

Test Artifacts
Data mapping > maps expressions from json view Test Replay Screenshots Video
Failed  20-workflow-executions.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  45-workflow-selector-parameter.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  30-editor-after-route-changes.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  6-code-node.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 51 specs in Cypress Cloud.

Flakiness  e2e/19-execution.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Execution > should send proper payload for node rerun Test Replay Screenshots Video

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants