-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Upgrade Toolpad to React 19 #4488
base: master
Are you sure you want to change the base?
Conversation
Upgrading all packages allowed most of the breaking types checks to pass, but there are some strange integration test failures. 1. "can move elements in page"Fails locally as well, moving text fields causes the @apedroferreira any ideas?
2. "data providers" and "data providers crud"pass locally, fail in CI |
Not sure at first glance... probably something to do with the logic we have for the controlled state and possibly bindings, probably will take some deeper looking into. I could also try once I have the time as I have also touched that logic some time ago. |
I found the fix for the text fields, looks like I can't push it to your repo directly?
It looks like this effect recommended by |
@apedroferreira @Janpot The two data grid related tests which are exceeding timeouts is most likely due to mui/mui-x#15770 I've skipped those two pending the fix of this issue to unblock the upgrade, wdyt? The tests pass if I increase the timeout locally to a very high number: I can not reproduce the Argos change reported as well: |
react
,react-dom
,@types/react
and@types/react-dom
to^19
docs
andstudio*
)npx codemod@latest types-react-codemod preset-19
npx codemod@latest react/19/migration-recipe
(excludingreact/prop-types-typescript
)