WIP: independence tests for categorical variables #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 83.99% 84.95% +0.95%
==========================================
Files 7 7
Lines 606 638 +32
==========================================
+ Hits 509 542 +33
+ Misses 97 96 -1
Continue to review full report at Codecov.
|
|
Do you think you can make this work without my input? Please merge once you think this is fine. |
|
Sure, no problem |
mschauer
approved these changes
May 29, 2019
|
@schnirz Is this "okay enough" for me to just merge? |
|
@mschauer I finally have some time this month to do more work on this, will let you know once I have some sensible ready. |
|
This is great news. There has been also some interest for this package in the last weeks, so this would be a good time. |
|
Yearly reminder ;-) |
Closed
mschauer
reviewed
Sep 28, 2021
| c = Tables.columns(t) | ||
| sch = Tables.schema(t) | ||
| n = length(sch.names) | ||
|
|
||
| return pcalg(n, cmitest, c, p; kwargs...) | ||
| return pcalg(n, cmitest, c, sch, p; kwargs...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented permutation-based independence tests for categorical variables based on mutual information and conditional mutual information
open questions: