-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eslint: add support for class properties #21259
Conversation
tehe! I been there. |
🤞 |
Seems to be working! Thanks! |
Unfortunately I have to revert this. Safari doesn't support class properties yet so all examples are currently broken. |
@mrdoob okay 👍 we'll have to wait then. We could also choose to transpile |
I think I'll wait until importmaps land in browsers. |
We are not using any feature related to import maps in the |
No we are not. But the development experience using |
I think you misunderstood 🙂 I meant removing the babel transpilation step for I am talking about these steps: three.js/utils/build/rollup.config.js Lines 343 to 348 in 4d90e23
The transpilation is just for modern es features (classes, let/const, arrow functions), the conversion from es modules to single umd file that users can use with |
I misunderstood indeed! We do still support IE11 in this example: And the current babel setup doesn't seem to cause problems so I see no reason for removing it. |
Related issue: #20009 (comment) (remake of #21238)
Description
Eslint also needs to know about babel to support class properties.
In this PR I added @babel/eslint-parser as a parser for eslint. This does not change the current eslint bahaviour.
Third time the charm?