Clear inactive assignee for old high-priority bugs without needinfo (#…

…2517)

bugbot/rules/assignee_no_login.py

@@ -3,6 +3,7 @@
 # You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import collections
+from datetime import datetime, timedelta
 
 from libmozdata import utils as lmdutils
 
@@ -23,6 +24,7 @@ def __init__(self):
         self.people = people.People.get_instance()
         self.unassign_count = collections.defaultdict(int)
         self.no_bugmail = True
+        self.one_year_ago = datetime.now() - timedelta(days=365)
 
         self.extra_ni = {}
 
@@ -104,9 +106,13 @@ def add_action(self, bug):
         # It's not paramount for triage owners to make an explicit decision here, it's enough for them
         # to receive the notification about the unassignment from Bugzilla via email.
         if (
-            bug["priority"] not in HIGH_PRIORITY
-            and bug["severity"] not in HIGH_SEVERITY
-        ) or "stalled" in bug["keywords"]:
+            (
+                bug["priority"] not in HIGH_PRIORITY
+                and bug["severity"] not in HIGH_SEVERITY
+            )
+            or "stalled" in bug["keywords"]
+            or (bug["is_old_priority"] and bug["priority"] in HIGH_PRIORITY)
+        ):
             needinfo = None
             autofix["comment"] = {
                 "body": "The bug assignee is inactive on Bugzilla, so the assignee is being reset."
@@ -126,12 +132,28 @@ def add_action(self, bug):
 
         self.add_prioritized_action(bug, bug["triage_owner"], needinfo, autofix)
 
+    def get_priority_change_date(self, bug):
+        current_priority = bug["priority"]
+
+        for change in reversed(bug["history"]):
+            if (
+                change["field_name"] == "priority"
+                and change["added"] == current_priority
+            ):
+                return datetime.strptime(change["when"], "%Y-%m-%dT%H:%M:%SZ")
+        return None
+
     def handle_bug(self, bug, data):
         bugid = str(bug["id"])
         if "triage_owner_detail" not in bug:
             logger.warning("Skip bug %s: no triage owner", bugid)
             return None
 
+        priority_change_date = self.get_priority_change_date(bug)
+        is_old_priority = (
+            priority_change_date and priority_change_date < self.one_year_ago
+        )
+
         data[bugid] = {
             "assigned_to": bug["assigned_to"],
             "triage_owner": bug["triage_owner"],
@@ -142,6 +164,7 @@ def handle_bug(self, bug, data):
             "priority": bug["priority"],
             "severity": bug["severity"],
             "keywords": bug["keywords"],
+            "is_old_priority": is_old_priority,
         }
 
         return bug
@@ -158,6 +181,7 @@ def get_bz_params(self, date):
             "priority",
             "severity",
             "keywords",
+            "history",
         ]
         params = {
             "include_fields": fields,