Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1613179 - Hide Phabricator related attachments from the attachment list and rely on phabricator table instead #1497

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bug 1613179 - Hide Phabricator related attachments from the attachment list and rely on phabricator table instead #1497

wants to merge 2 commits into from

Conversation

dklawren
Copy link
Collaborator

@dklawren dklawren commented Feb 4, 2020

No description provided.

@dklawren
Bug 1613179 - Hide Phabricator related attachments from the attachmen…
af4dd3b 
…t list and rely on phabricator table instead
@dklawren dklawren requested a review from globau February 4, 2020 17:33
@kyoshino
Copy link
Collaborator

kyoshino commented Feb 5, 2020

Is this the same as #1159? It was backed out in #1175 due to uplift difficulties.

@dklawren
Copy link
Collaborator Author

dklawren commented Feb 5, 2020

Is this the same as #1159? It was backed out in #1175 due to uplift difficulties.

Ah yeah. It was long enough ago I forgot about the old one we backed out. This change came up again at allhands and of course it seemed like an easy fix. But as you recall, it messed up some things.

What if I were to add a link in the new phabricator table instead to the details page for now?

@kyoshino
Copy link
Collaborator

kyoshino commented Feb 5, 2020

Yup, we just need to figure out how to merge the Details links with the Phab section :-)

@dklawren dklawren requested a review from kyoshino February 6, 2020 20:54
@kyoshino
Copy link
Collaborator

Was checking this but it seems I can’t test Phab stuff locally without actual bug data. I should probably request a BMO DB snapshot again 😆

@kyoshino kyoshino removed their request for review February 10, 2020 04:19
@globau
Copy link
Collaborator

globau commented Feb 10, 2020

What if I were to add a link in the new phabricator table instead to the details page for now?

Not necessary - uplifts are moving to Phabricator; let's wait for that to happen before doing this.

@globau globau removed their request for review February 10, 2020 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dklawren @kyoshino @globau