Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename osi DS -> spdx-license-list #222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename osi DS -> spdx-license-list #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data-sources/osi.yaml → data-sources/spdx-license-list.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
version: v1
type: data-source
name: osi
Copy link
Contributor

@blkt blkt Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would name it just spdx, as we might add more functions to it.

This is not as trivial as it might seem, since changing this name is a breaking change because rules use the data source name as namespace for its functions. The name should not reflect the functions, but the data source itself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this, let's take @blkt 's recommendation

name: "spdx-license-list"
context: {}
rest:
def:
Expand Down
Loading