Add AF_XDP transmit checksum offload #375
Conversation
…ic proof-of-concept
…ic proof-of-concept
mtfriesen
added
feature request
…icrosoft/xdp-for-windows into mtfriesen/udp_checksum_uso_poc
mtfriesen
changed the title
| @@ -94,6 +95,8 @@ XdpExtensionSetAssignLayout( | |||
| UINT8 MaxAlignment = BaseAlignment; | |||
| UINT8 CurrentAlignment; | |||
|
|
|||
| FRE_ASSERT(!ExtensionSet->LayoutAssigned); | |||
There was a problem hiding this comment.
Why did you choose a free assert instead of a debug?
There was a problem hiding this comment.
This module includes enforcement of the native XDP driver API, so these FRE_ASSERTs are designed to detect driver misbehavior on any system, not just with CHK builds. It's not a performance-sensitive path.
There was a problem hiding this comment.
If you had support for driver verifier, would you enable these only if driver verifier was enabled? QUIC has 4 types of assert validation:
- Debug
- Telemetry
- Free
- Verifier
We haven't made a huge distinction, but the verifier ones are nice if the assert is about external conformance.
There was a problem hiding this comment.
Agreed, we would ideally have a separate verifier mode. Right now we just have debug/release builds, plus a knob to make the debug build also inject random failures.
Description
Describe the purpose of and changes within this Pull Request.
Add AF_XDP transmit checksum offload: add a socket option to enable the offload, as well as socket options to query the assigned extension offsets within each AF_XDP frame descriptor.
Testing
Do any existing tests cover this change? Are new tests needed?
Added functional and spin tests.
Documentation
Is there any documentation impact for this change?
No, this is still in experimental headers. There is some documentation added to those headers.
Installation
Is there any installer impact for this change?
No.