Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
mtfriesen committed Feb 13, 2024
1 parent 1b18b8b commit 92a41d2
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 5 deletions.
17 changes: 12 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,14 @@ on:
required: false
default: false
type: bool
# options:
# - true
# - false
upload_artifacts:
required: false
default: false
type: bool
publish_symbols:
required: false
default: false
type: bool

permissions:
actions: read
Expand All @@ -57,7 +62,9 @@ jobs:
- name: Checkout repository
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
with:
repository: microsoft/xdp-for-windows
submodules: recursive
ref: ${{ inputs.ref }}
- name: Initialize CodeQL
if: ${{ github.event_name == 'schedule' }}
uses: github/codeql-action/init@v3
Expand Down Expand Up @@ -87,7 +94,7 @@ jobs:
shell: PowerShell
run: tools/create-installer.ps1 -Config ${{ inputs.config }} -Platform ${{ inputs.arch }}
- name: Upload Artifacts
if: inputs.os == 2022
if: inputs.upload_artifacts
uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3
with:
name: bin_${{ inputs.config }}_${{ inputs.arch }}
Expand All @@ -98,7 +105,7 @@ jobs:
!artifacts/bin/**/*.lastcodeanalysissucceeded
- name: Publish Symbols
uses: microsoft/action-publish-symbols@719c40b80e38bca806f3e01e1e3dd3a67554cd68
if: github.event_name != 'pull_request' && inputs.os == 2022
if: inputs.publish_symbols
with:
accountName: mscodehub
symbolServiceUrl: 'https://artifacts.dev.azure.com'
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ jobs:
arch: ${{ matrix.arch }}
if: ${{ github.event_name == 'schedule' }}
codeql: true
if: matrix.os == 2022
upload_artifacts: true
if: github.event_name != 'pull_request' && matrix.os == 2022
publish_symbols: true

functional_tests:
name: Functional Tests
Expand Down

0 comments on commit 92a41d2

Please sign in to comment.