Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Google.PlatformTools version 35.0.2 #190804

Conversation

ponces
Copy link
Contributor

@ponces ponces commented Nov 12, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Manifest-Version-Error Unsupported manifest version label Nov 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 12, 2024
Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ponces,

I'm not entirely sure, but I believe that 1.7.0 is the highest manifest version currently supported.

@ponces
Copy link
Contributor Author

ponces commented Nov 13, 2024

Hi @ponces,

I'm not entirely sure, but I believe that 1.7.0 is the highest manifest version currently supported.

The thing is the flag ArchiveBinariesDependOnPath was only introduced on 1.9.0.
AFAIK this is the highest manifest version, though it's not wide published yet.
The fix was merged in microsoft/winget-cli#4816.
I can locally use this fix while using winget-cli v1.9.25180 and these new manifests.

This flag fixes the issues microsoft/winget-cli#2711 and microsoft/winget-cli#2889 for this package.
Is there any plan to publish the new 1.9.0 manifest version?
I can leave this PR as a draft until then.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 13, 2024
@ItzLevvie
Copy link
Contributor

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Version-Error Unsupported manifest version Needs-Attention This work item needs to be reviewed by a member of the core team. labels Nov 15, 2024
@wingetbot wingetbot added the Manifest-Version-Error Unsupported manifest version label Nov 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 15, 2024
@ponces ponces marked this pull request as draft November 17, 2024 00:06
@ponces
Copy link
Contributor Author

ponces commented Nov 18, 2024

Hello @ponces,

The package manager bot determined that the ManifestVersion key does not match any version currently approved for release. Please verify the manifest file is compliant with the package manager 1.5 manifest specification or 1.6 manifest specification.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/version/error

The thing is the flag ArchiveBinariesDependOnPath was only introduced on 1.9.0. AFAIK this is the highest manifest version, though it's not wide published yet. The fix was merged in microsoft/winget-cli#4816. I can locally use this fix while using winget-cli v1.9.25180 and these new manifests.

This flag fixes the issues microsoft/winget-cli#2711 and microsoft/winget-cli#2889 for this package. Is there any plan to publish the new 1.9.0 manifest version? I can leave this PR as a draft until then.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 18, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Version-Error Unsupported manifest version Needs-Attention This work item needs to be reviewed by a member of the core team. labels Dec 4, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Changes-Requested Changes Requested label Dec 4, 2024
@ponces
Copy link
Contributor Author

ponces commented Dec 4, 2024

Just a few suggestions/fixes.

I verified this PR locally. If the validation pipeline is rerun this will pass.

Thanks

Copy link
Contributor

@aisgbnok aisgbnok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

--> Installing WinGet
--> Disabling safety warning when running installers
Tip: you can type 'Update-EnvironmentVariables' to update your environment variables, such as after installing a new software.

--> Configuring Winget
Enabled admin setting 'LocalManifestFiles'.
Enabled admin setting 'LocalArchiveMalwareScanOverride'.

--> Installing the Manifest 35.0.2

Found Android SDK Platform-Tools [Google.PlatformTools] Version 35.0.2
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://dl.google.com/android/repository/platform-tools_r35.0.2-win.zip
██████████████████████████████  6.39 MB / 6.39 MB
Successfully verified installer hash
Extracting archive...
Successfully extracted archive
Starting package install...
Path environment variable modified; restart your shell to use the new value.
Command line alias added: "adb"
Command line alias added: "fastboot"
Successfully installed

--> Refreshing environment variables

--> Comparing ARP Entries

DisplayName                DisplayVersion Publisher  ProductCode                         Scope
-----------                -------------- ---------  -----------                         -----
Android SDK Platform-Tools 35.0.2         Google LLC Google.PlatformTools__DefaultSource User


PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> adb --version
Android Debug Bridge version 1.0.41
Version 35.0.2-12147458
Installed as C:\Users\WDAGUtilityAccount\AppData\Local\Microsoft\WinGet\Packages\Google.PlatformTools__DefaultSource\platform-tools\adb.exe
Running on Windows 10.0.26100
PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> fastboot --version
fastboot version 35.0.2-12147458
Installed as C:\Users\WDAGUtilityAccount\AppData\Local\Microsoft\WinGet\Packages\Google.PlatformTools__DefaultSource\platform-tools\fastboot.exe
PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs>

@wingetbot
Copy link
Collaborator

Found duplicate pull request(s)

Copy link
Contributor Author

@ponces ponces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is everything ok?

@stephengillie
Copy link
Collaborator

Since logs are not currently emitted, my automation can't filter them to find the error. And there is too much PR volume for me to manually verify all errors. So I am only verifying those with discussion.

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 27348aa into microsoft:master Dec 6, 2024
2 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Dec 6, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@ponces ponces deleted the Google.PlatformTools-35.0.2-049d7224-c37e-40fc-8007-714230dadc2b branch December 7, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants