Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for screen reader users for simple suggest widget #236516

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Dec 18, 2024

fix #235022

copied from SuggestWidget and the below , which is downstream used by SuggestWidget

public setAriaOptions(options: IEditorAriaOptions): void {
if (options.activeDescendant) {
this._domNode.setAttribute('aria-haspopup', 'true');
this._domNode.setAttribute('aria-autocomplete', 'list');
this._domNode.setAttribute('aria-activedescendant', options.activeDescendant);
} else {
this._domNode.setAttribute('aria-haspopup', 'false');
this._domNode.setAttribute('aria-autocomplete', 'both');
this._domNode.removeAttribute('aria-activedescendant');
}
if (options.role) {
this._domNode.setAttribute('role', options.role);
}
}

Screenshot 2024-12-18 at 1 56 45 PM

@meganrogge meganrogge requested a review from Tyriar December 18, 2024 20:02
@meganrogge meganrogge self-assigned this Dec 18, 2024
@meganrogge meganrogge added this to the January 2025 milestone Dec 18, 2024
@meganrogge meganrogge enabled auto-merge (squash) December 18, 2024 20:02
@meganrogge meganrogge changed the title get terminal completions to work for screen reader users add support for screen reader users for simple suggest widget Dec 18, 2024
@meganrogge meganrogge force-pushed the merogge/terminal-aria branch 2 times, most recently from 25f31c4 to 8c3327a Compare December 18, 2024 20:14
@meganrogge meganrogge merged commit 0900a62 into main Dec 18, 2024
8 checks passed
@meganrogge meganrogge deleted the merogge/terminal-aria branch December 18, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terminal completions are not indicated to screen reader users
2 participants