fix regression with terminal tabs/panel #236500
Closed
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
Dec 18, 2024
| @@ -217,6 +217,7 @@ export class TerminalViewPane extends ViewPane { | |||
| // defer focusing the panel to the focus() call | |||
| // to prevent overriding preserveFocus for extensions | |||
| this._terminalGroupService.showPanel(false); | |||
| this.focus(); | |||
There was a problem hiding this comment.
This seems to contradict the comment above. I don't think toggling visibility means it must also focus?
There was a problem hiding this comment.
focus was previously called by the pane view container
There was a problem hiding this comment.
also, see how our focus function only focuses under certain conditions
|
Closing because this will cause problems - esp as it relates to our API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #235931
With this change #235931 (comment), we now have to call the view container's
focuswhen it becomes visiblepanel.mov