Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leak in settings indicators #236417

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SimonSiefke
Copy link
Contributor

This fixes a memory leak in the settings indicators.

Currently the function only clears the scopeOverridesIndicator in one if condition but not in others:

this.scopeOverridesIndicator.disposables.clear();

This means that the hover disposables added here

this.addHoverDisposables(this.scopeOverridesIndicator.disposables, this.scopeOverridesIndicator.element, showHover);

are not being cleared when calling updateScopeOverrides.

@rzhao271 rzhao271 added this to the January 2025 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants