Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminal completions are not indicated to screen reader users #235022

Closed
meganrogge opened this issue Dec 2, 2024 · 3 comments · Fixed by #236516
Closed

terminal completions are not indicated to screen reader users #235022

meganrogge opened this issue Dec 2, 2024 · 3 comments · Fixed by #236516
Assignees
@meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug terminal-suggest unreleased Patch has not yet been released in VS Code Insiders
Milestone
January 2025

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Dec 2, 2024 •
edited
Loading

  1. enable terminal.integrated.suggest.enabled and (optional) terminal.integrated.suggest.enableExtensionCompletions
  2. use a screen reader and enter screen reader mode
  3. type in the terminal, for example, c
  4. completions widget is visible, but it's not announced to screen reader users

Completions in the editor aren't announced to screen reader users, but when they're invoked via ctrl+space, they are and say the suggestion then x of count.

cc @jooyoungseo
@meganrogge meganrogge added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues terminal-suggest bug Issue identified by VS Code Team member as probable bug labels Dec 2, 2024
@meganrogge meganrogge added this to the January 2025 milestone Dec 2, 2024
@meganrogge
Copy link
Contributor Author

We'll need to fix this first #233921

@jooyoungseo
Copy link

It's verbally announced on Windows when tested with the latest JAWS. However, the terminal suggestion is not presented in a braille display.

@Tyriar
Copy link
Member

Tyriar commented Dec 2, 2024

@meganrogge my guess is this is either the terminal's announcing conflicting with it or the simple suggest widget missing some a11y stuff.

@Tyriar Tyriar removed their assignment Dec 9, 2024
meganrogge added a commit that referenced this issue Dec 18, 2024
@meganrogge
fix #235022
8c3327a
@meganrogge meganrogge mentioned this issue Dec 18, 2024
Merged
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug terminal-suggest unreleased Patch has not yet been released in VS Code Insiders
Projects
None yet
Milestone
January 2025
Development

Successfully merging a pull request may close this issue.

add support for screen reader users for simple suggest widget microsoft/vscode
3 participants
@Tyriar @jooyoungseo @meganrogge