@ulugbekna I can't repro, could you check devtools console for errors?

I don't see any related errors in dev console.

Are you also on mac and use zsh? Could you try reproing in copilot repo with all 3 tasks running and an extra terminal as in my screencast?

I was trying on Windows because the OS shouldn't matter for this. Regardless, passing to @meganrogge as main owner of tabs now

did you toggle/untoggle zen mode? if so, can repro and is a duplicate of #176085

I cannot repro when I toggle panel visibility though on mac

started seeing this recently. maybe need to bisect

@benibenj , git bisect points to this commit: d5746c5

The only change is that toggling the panel does not give focus to the view anymore (#232790). The rendering of the view should not depend on getting focus but on visibility change

Might want to let other view owners know about this change, I see that the debug console used to receive focus on visibility change, but now does not for example.

I don't mean that the views should take focus when they become visible. They layout/views logic tells your view when to be focused. The problem here seems to be that the terminal only renders correctly when it gets focused, which should not be the case. You need to make sure it renders properly when the visibility of the view changes.

I think #236502 should be reverted. It behaved correctly before

I think #236502 should be reverted. It behaved correctly before

It did not behave correctly before - it did not move focus to the debug console input box like it should and like it does in VS Code stable. This is an accessibility issue.

Stable:

Insiders:

The problem here seems to be that the terminal only renders correctly when it gets focused, which should not be the case. You need to make sure it renders properly when the visibility of the view changes.

This is not just about rendering. The terminal has historically received focus when the panel becomes visible.

This change really should have had a larger audience before it happened with pings to owners of panel views. Ctrl/cmd+j has been around forever and people depend upon it. Consistency is good, but we must have a roll out plan for something like this that changes such old/core behavior.

The problem here seems to be that the terminal only renders correctly when it gets focused, which should not be the case.

I agree with this, but the main issue @meganrogge is talking about wrt accessibility is the focus part. The layout problem is just another unfortunate affect of this change.

They layout/views logic tells your view when to be focused.

The terminal cannot do this or we would break other things like the Terminal.show(preserveFocus) extension API. At the very least
it's not as simple as just just focusing on visibility, how to get the old behavior back is not obvious to me.

imo we should revert all the changes include the original change and have the discussion about it first. This is also the lowest risk approach since most of us are about to be offline.

@benibenj FWIW the purest in me agrees with you, but I think we've had this behavior for too long and we'd be better off going in the other direction where ctrl/cmd+j shows AND focuses any panel or hides it, similar to the ctrl+` behavior. A bonus of going this route is we could use a conditional keybinding to call a showAndFocus command, so if the user really wanted to just toggle the panel they can unbound the showAndFocus one.