utils: Introduce validationUtils namespace & character length validation logic
#1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into mwf/validation-utils-1
MicroFish91
commented
Jan 2, 2024
| * @property `lowerLimitIncl`: The minimum size of the range (inclusive) | ||
| * @property `upperLimitIncl`: The maximum size of the range (inclusive) | ||
| */ | ||
| export interface RangeConstraints { |
There was a problem hiding this comment.
Kept this named more generically because I was planning to reuse this interface again later for another validation method covering numeric range
bwateratmsft
changed the title
validationUtils namespace & character length validation logicvalidationUtils namespace & character length validation logic
nturinski
reviewed
Jan 23, 2024
utils/src/utils/validationUtils.ts
Outdated
| export function hasValidCharLength(value: string, rc?: RangeConstraints): boolean { | ||
| const lowerLimitIncl = (!rc?.lowerLimitIncl || rc.lowerLimitIncl < 1) ? 1 : rc.lowerLimitIncl; | ||
| const upperLimitIncl = (!rc?.upperLimitIncl || rc.upperLimitIncl > Number.MAX_SAFE_INTEGER) ? Number.MAX_SAFE_INTEGER : rc.upperLimitIncl; | ||
| return lowerLimitIncl <= upperLimitIncl && value.length >= lowerLimitIncl && value.length <= upperLimitIncl; |
There was a problem hiding this comment.
I feel like that this should just throw an error: lowerLimitIncl <= upperLimitIncl. If the upperLimit is lower than the lowerLimit, somebody created the RangeConstraints backwards and that'd be kind of difficult to understand what's going wrong.
|
Added a message condition for when the lower and upper limits are equal* |
MicroFish91
force-pushed
the
mwf/validation-utils-1
branch
from
5c15fb3 to
57c3b52
Compare
MicroFish91
force-pushed
the
mwf/validation-utils-1
branch
from
57c3b52 to
81fa32b
Compare
nturinski
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning of a series of PRs to add a validation utility to simplify common input string validation scenarios for use in our Azure Wizard
inputBoxsteps.Example of use:
See: microsoft/vscode-azurecontainerapps#582
Let me know if you think something like this would be useful :)