Add retries for container app updates that fail after enabling admin credential-based access #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroFish91
force-pushed
the
mwf/adorable-plum
branch
from
eafd5c5 to
e0a7003
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #791
From my experience, this error is specifically due to needing more time for the admin credentials to propagate. This does not reproduce for managed identities.
The reason this often doesn't reproduce for workspace project deployments is because there's a natural delay taken since ACR needs to build the image first, and so often the permissions have finished propagating by the time the image is ready.
This natural delay doesn't happen in cases where the image already exists, so we should add retries to help stabilize this issue.