Add deleteEnvironmentVariable command
#798
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturinski
reviewed
Dec 13, 2024
| import { type EnvironmentVariablesBaseContext } from "../EnvironmentVariablesContext"; | ||
|
|
||
| export interface EnvironmentVariableDeleteBaseContext extends EnvironmentVariablesBaseContext { | ||
| environmentVariable: EnvironmentVar; |
There was a problem hiding this comment.
Should this just be part of the edit context?
There was a problem hiding this comment.
Just to clarify, which of the edit contexts are you referring to?
nturinski
reviewed
Dec 13, 2024
| }; | ||
| wizardContext.telemetry.properties.revisionMode = containerApp.revisionsMode; | ||
|
|
||
| const confirmMessage: string = localize('confirmDeleteEnv', 'Are you sure you want to delete environment variable "{0}"?', item.envVariable.name); |
There was a problem hiding this comment.
Should we put a message saying that this isn't destructible (until you upload the draft?)
There was a problem hiding this comment.
Yeah that's a good idea. Maybe I can add (draft) to the message to help clarify this, do you think that would be clear enough?
nturinski
approved these changes
Dec 13, 2024
…-azurecontainerapps into mwf/running-coffee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.