-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization to Serbian (sr-Cyrl-RS) #17995
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
Unfortunately, we're currently integrated with Microsoft's internal localization service and that's where our translations are coming from. I suppose in theory we could merge this, but in practice it's probably not possible because of that. |
Oh, no, as long as we are not getting Serbian translations from Touchdown we can accept community contributions! We just need a process to make sure the language stays up to date as we add new text. |
I can commit myself to update this localization. Certainly, I won't abandon it without ensuring a clear way forward with maintainers (@DHowett) |
After giving it some thought, we decided that we should merge your PR, because having some translation is better than having none. We'd essentially put the stewardship of keeping the translation up to date into the stewardship of the community. Our UI framework (WinUI) will fall back to English or some other secondary language if a Serbian translation string is unavailable. |
x-linking this to #10667. This PR seems like it's the prototypical case of "if it's not one of the automatic translations, then the community is free to add their own. @eevan78 Is there a reason this PR is still a draft? IIRC we have to manually list out the languages we support in either our Package.appxmanifest or... some other file. Somewhere in the settings editor, where we pick the languages? But if this works, then let's merge it |
@zadjii-msft this is my first contribution to this project, and I was not completely sure if I have picked up all places with the source strings. Now that there is a decision to merge it, there is no need to keep it as a draft anymore. I think that I have translated everything. |
Summary of the Pull Request
This PR introduce the initial localization to Serbian (sr-Cyrl-RS)
References and Relevant Issues
Detailed Description of the Pull Request / Additional comments
I have added the Resources.resw files. I'm not sure if anything else should be added/changed.
Validation Steps Performed
PR Checklist