Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization to Serbian (sr-Cyrl-RS) #17995

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eevan78
Copy link

@eevan78 eevan78 commented Oct 4, 2024

Summary of the Pull Request

This PR introduce the initial localization to Serbian (sr-Cyrl-RS)

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

I have added the Resources.resw files. I'm not sure if anything else should be added/changed.

Validation Steps Performed

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

@eevan78
Copy link
Author

eevan78 commented Oct 4, 2024

@microsoft-github-policy-service agree

@lhecker
Copy link
Member

lhecker commented Oct 10, 2024

Unfortunately, we're currently integrated with Microsoft's internal localization service and that's where our translations are coming from. I suppose in theory we could merge this, but in practice it's probably not possible because of that.

@DHowett
Copy link
Member

DHowett commented Oct 10, 2024

Oh, no, as long as we are not getting Serbian translations from Touchdown we can accept community contributions! We just need a process to make sure the language stays up to date as we add new text.

@eevan78
Copy link
Author

eevan78 commented Oct 11, 2024

I can commit myself to update this localization. Certainly, I won't abandon it without ensuring a clear way forward with maintainers (@DHowett)

@lhecker lhecker added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Dec 4, 2024
@lhecker
Copy link
Member

lhecker commented Dec 9, 2024

After giving it some thought, we decided that we should merge your PR, because having some translation is better than having none. We'd essentially put the stewardship of keeping the translation up to date into the stewardship of the community. Our UI framework (WinUI) will fall back to English or some other secondary language if a Serbian translation string is unavailable.

@zadjii-msft
Copy link
Member

x-linking this to #10667. This PR seems like it's the prototypical case of "if it's not one of the automatic translations, then the community is free to add their own.

@eevan78 Is there a reason this PR is still a draft?

IIRC we have to manually list out the languages we support in either our Package.appxmanifest or... some other file. Somewhere in the settings editor, where we pick the languages? But if this works, then let's merge it

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Dec 13, 2024
@eevan78
Copy link
Author

eevan78 commented Dec 14, 2024

@zadjii-msft this is my first contribution to this project, and I was not completely sure if I have picked up all places with the source strings.
Hence I marked it as a draft.

Now that there is a decision to merge it, there is no need to keep it as a draft anymore. I think that I have translated everything.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 14, 2024
@lhecker lhecker marked this pull request as ready for review December 17, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Attention The core contributors need to come back around and look at this ASAP.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants