Enable QueryStore tab to the database properties #2200
Conversation
ssreerama
requested review from
corivera,
Charles-Gagnon,
barbaravaldez and
chlafreniere
| @@ -89,6 +98,33 @@ static DatabaseHandler() | |||
| displayFileTypes.TryAdd(FileType.Log, SR.prototype_file_logFile); | |||
| displayFileTypes.TryAdd(FileType.FileStream, SR.prototype_file_filestreamFile); | |||
|
|
|||
| displayOperationModeOptions.TryAdd(QueryStoreOperationMode.Off, CommonConstants.QueryStoreOperationMode_Off); | |||
There was a problem hiding this comment.
I don't think we should be localizing option values like OFF and READ_ONLY - do we do that in SSMS?
@erinstellato-ms what do you think?
There was a problem hiding this comment.
Other couple of dropdown options(All,Auto,None,Custom) are translated in the MS quey store help doc, so localized these too.
There was a problem hiding this comment.
What's our general practice on localizing options in ADS? Specifically, options in a drop down? Example: Backup functionality (in preview), we have Set backup compression as a drop down with three options. Are those localized?
Fundamentally...first, let's be consistent across ADS. Second, I will have to install another language of SSMS to see what we do there :)
There was a problem hiding this comment.
I have created a task to verify and add/remove all such dropdown options:
#2213
| } | ||
| catch (Exception ex) | ||
| { | ||
| areQueryStorePropertiesInitialized = false; |
There was a problem hiding this comment.
What exception are you expecting to be thrown here? I'm not sure what "initialized" would mean in this case, or why we'd want to skip setting the values completely in that case.
There was a problem hiding this comment.
While create database the value this.currentState.queryStoreOptions is not null but its properties (ex: DesiredState...etc) throws "'this.currentState.queryStoreOptions.DesiredState' threw an exception of type 'System.NullReferenceException'"
src/Microsoft.SqlTools.ServiceLayer/Admin/Database/DatabasePrototype130.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.SqlTools.ServiceLayer/Admin/Database/DatabasePrototype.cs
Outdated
Show resolved
Hide resolved
This PR adds the ability to view/update query store options to the database proeprties.