-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Copilot Chat: support multiple document import (#1675)
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Copilot Chat currently only supports importing a single document at a time. Supporting multiple documents will improve user experience. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. Add multi-document support in DocumentImportController. Did a little refactoring too. 2. Create a configurable limit on the number of documents that can be imported at a time. It's currently set to 10. 3. Enable support in the webapp, both drag&drop and file explorer. Update the document history item to show multiple files. 4. Update the import document console app to support multi-doc import. ![image](https://github.com/microsoft/semantic-kernel/assets/12570346/64e025fb-de71-4bef-9903-08ad570c5e1e) Future work: https://github.com/orgs/microsoft/projects/852/views/1?pane=issue&itemId=31798351 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Aman Sachan <[email protected]>
- Loading branch information
1 parent
5e70eef
commit 36f4e7c
Showing
14 changed files
with
448 additions
and
155 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.