Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic-exporter): Add dynamic flow exporter support for hubble #1026

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anubhabMajumdar
Copy link
Contributor

@anubhabMajumdar anubhabMajumdar commented Nov 19, 2024

Description

Adding support for dynamic flow exporter in Hubble.
Read more about dynamic flow exporter here.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

$ kno aks-nodepool1-10725549-vmss000000
root@aks-nodepool1-10725549-vmss000000:/# tail -f /var/run/retina/hubble/events.log
...
{"flow":{"time":"2024-11-19T22:35:33.343220551Z","verdict":"FORWARDED","IP":{"source":"192.168.2.38","destination":"10.224.0.4","ipVersion":"IPv4"},"l4":{"TCP":{"source_port":46518,"destination_port":10250,"flags":{"ACK":true}}},"source":{"ID":31432,"identity":31432,"namespace":"kube-system","pod_name":"konnectivity-agent-7d494c7d79-7pm4z"},"destination":{"ID":1,"identity":1,"labels":["reserved:host"]},"Type":"L3_L4","event_type":{"type":4,"sub_type":3},"traffic_direction":"EGRESS","trace_observation_point":"TO_STACK","is_reply":false,"Summary":"TCP Flags: ACK:true","extensions":{"@type":"type.googleapis.com/utils.RetinaMetadata","bytes":66}},"time":"2024-11-19T22:35:33.343220551Z"}
{"flow":{"time":"2024-11-19T22:35:33.343337550Z","verdict":"FORWARDED","IP":{"source":"192.168.2.38","destination":"10.224.0.4","ipVersion":"IPv4"},"l4":{"TCP":{"source_port":46518,"destination_port":10250,"flags":{"ACK":true}}},"source":{"ID":31432,"identity":31432,"namespace":"kube-system","pod_name":"konnectivity-agent-7d494c7d79-7pm4z"},"destination":{"ID":1,"identity":1,"labels":["reserved:host"]},"Type":"L3_L4","event_type":{"type":4,"sub_type":3},"traffic_direction":"EGRESS","trace_observation_point":"TO_STACK","is_reply":false,"Summary":"TCP Flags: ACK:true","extensions":{"@type":"type.googleapis.com/utils.RetinaMetadata","bytes":66}},"time":"2024-11-19T22:35:33.343337550Z"}
root@aks-nodepool1-10725549-vmss000000:/# ls -la /var/run/retina/hubble
total 51480
drwxr-xr-x 2 root root      160 Nov 19 22:35 .
drwxr-xr-x 3 root root       60 Nov 19 01:53 ..
-rw-r--r-- 1 root root 10485267 Nov 19 16:32 events-2024-11-19T16-32-15.656.log
-rw-r--r-- 1 root root 10485050 Nov 19 16:49 events-2024-11-19T16-49-23.125.log
-rw-r--r-- 1 root root 10485079 Nov 19 17:06 events-2024-11-19T17-06-33.124.log
-rw-r--r-- 1 root root 10485306 Nov 19 17:23 events-2024-11-19T17-23-47.045.log
-rw-r--r-- 1 root root 10485271 Nov 19 22:35 events-2024-11-19T22-35-48.976.log
-rw-r--r-- 1 root root   284620 Nov 19 22:36 events.log
root@aks-nodepool1-10725549-vmss000000:/#

Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@anubhabMajumdar anubhabMajumdar requested a review from a team as a code owner November 19, 2024 01:59
@anubhabMajumdar anubhabMajumdar marked this pull request as draft November 19, 2024 01:59
@anubhabMajumdar anubhabMajumdar force-pushed the topic/anmajumdar/exporter branch 2 times, most recently from 509d3a4 to 100f5b5 Compare November 19, 2024 22:29
@anubhabMajumdar anubhabMajumdar marked this pull request as ready for review November 19, 2024 22:37
@anubhabMajumdar anubhabMajumdar force-pushed the topic/anmajumdar/exporter branch from 100f5b5 to 0e92786 Compare November 19, 2024 22:37
Copy link
Contributor

@nddq nddq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nit comments but lgtm otherwise

Makefile Outdated Show resolved Hide resolved
controller/Dockerfile Show resolved Hide resolved
@anubhabMajumdar anubhabMajumdar force-pushed the topic/anmajumdar/exporter branch 2 times, most recently from fcc46d8 to 41c4809 Compare November 20, 2024 18:12
@anubhabMajumdar anubhabMajumdar force-pushed the topic/anmajumdar/exporter branch from 41c4809 to 3c41e70 Compare November 20, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants