[nodejs binding] Fix building in latest clang #23146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes the build break for Node.js binding on latest AppleClang:
Use the underlying type of enum
napi_typedarray_type
forDATA_TYPE_TYPEDARRAY_MAP
to solve this issue.Because the underlying type is implementation defined (it's
int
for MSVC andunsigned int
for Clang), we usestd::underlying_type_t
to get the correct type.