Updated getIndexInfo() to include Columnstore indexes by using custom query. #2563
+196
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… query Replaced the use of the sp_statistics stored procedure with a custom query to retrieve index information as the sp_statistics procedure did not return Columnstore indexes, so a query using sys.indexes was implemented as a workaround. This new query ensures that all index types (Clustered, NonClustered, Columnstore) are included in the result set. Github Issue: #2546
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2563 +/- ##
============================================
+ Coverage 51.03% 51.10% +0.06%
- Complexity 3919 3930 +11
============================================
Files 147 147
Lines 33456 33445 -11
Branches 5604 5602 -2
============================================
+ Hits 17074 17091 +17
+ Misses 13971 13964 -7
+ Partials 2411 2390 -21 ☔ View full report in Codecov by Sentry. |
…columnstore indexes
machavan
reviewed
Dec 16, 2024
src/test/java/com/microsoft/sqlserver/jdbc/DatabaseMetadataTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/DatabaseMetadataTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/DatabaseMetadataTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/DatabaseMetadataTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
Show resolved
Hide resolved
machavan
reviewed
Dec 16, 2024
src/test/java/com/microsoft/sqlserver/jdbc/DatabaseMetadataTest.java
Outdated
Show resolved
Hide resolved
|
Changes have already been requested as a part of #2566, hence closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the use of the sp_statistics stored procedure with a custom query to retrieve index information as the sp_statistics procedure did not return Columnstore indexes, so a query using sys.indexes was implemented as a workaround.
This new query ensures that all index types (Clustered, NonClustered, Columnstore) are included in the result set.
Github Issue: #2546