Auto generate rust bindings #4696
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youyuanwu
commented
Dec 9, 2024
| @@ -143,8 +143,10 @@ mod status { | |||
| #[cfg(target_os = "linux")] | |||
There was a problem hiding this comment.
I must have run cargo fmt. This might need to be reverted.
There was a problem hiding this comment.
Yeah, let's revert that, and maybe bring it in a separate PR if you think it's really needed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4696 +/- ##
==========================================
+ Coverage 85.87% 86.68% +0.80%
==========================================
Files 56 56
Lines 17361 17361
==========================================
+ Hits 14909 15049 +140
+ Misses 2452 2312 -140 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The FFI definitions for rust should be auto generated instead of manually written.
This PR adds a new rust crate with auto generated bindings aiming to replace or remove all the manual bindings in the existing crate. Existing code is not changed. In future, the safe rust wrappers should be written on top of this generated bindings.
The generated code is from winmd and windows-bindgen tool chain and is cross platform. It does not have any function that requires linking, and I plan to leave those functions to be dynamically loaded.
Testing
NA
Documentation
TBD