Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLB Proto Update #267

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

SLB Proto Update #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c16e12e
Initial draft
mjethwa-msft Jun 5, 2024
edadea7
Updates to SLB proto
mjethwa-msft Jun 6, 2024
4b7337c
Add apiVersion
mjethwa-msft Jun 7, 2024
44e1c58
Update SLB proto
mjethwa-msft Jun 26, 2024
5528b3f
Remove read-only references from slb proto
mjethwa-msft Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions rpc/cloudagent/network/loadbalancer/moc_cloudagent_loadbalancer.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,35 @@ message LoadbalancerInboundNatRule {
Protocol protocol = 4;
}

message LoadbalancerOutboundNatRule {
string name = 1;
uint32 frontendPort = 2;
uint32 backendPort = 3;
Protocol protocol = 4;
}

message LoadBalancingRule {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoadBalancingRule

we need a name for this and other child resources

uint32 frontendPort = 1;
uint32 backendPort = 2;
Protocol protocol = 3;
ProbeReference probeRef = 4; // Update based on chat with Nithin
string name = 5;
}

message Probe {
string name = 1;
uint32 intervalInSeconds = 2;
uint32 numberOfProbes = 3;
Protocol protocol = 4;
uint32 port = 5;
}

message FrontEndIpConfiguration {
string name = 1;
string privateIPAddress = 2; // required if using subnet
IPAllocationMethod allocationMethod = 3; // required
SubnetReference subnetRef = 4; // required if using privateIPAddress.
PublicIPAddressReference publicIPAddress = 5; // required if not using privateIP and a subnet. resourceRef to publicIPAddress
}

message LoadBalancer {
Expand All @@ -59,6 +84,11 @@ message LoadBalancer {
Tags tags = 11;
uint32 replicationCount = 12;
repeated LoadbalancerInboundNatRule inboundNatRules = 13;
repeated LoadbalancerOutboundNatRule outboundNatRules = 14;
repeated FrontEndIpConfiguration frontendIpConfigurations = 15;
repeated Probe probes = 16; // Need more discussion around probes
string useSDN = 17; // To indicate SDN optionality
string apiVersion = 18;
}

service LoadBalancerAgent {
Expand Down
Loading
Loading