Convert sync over async network handling to async #835
+44
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1b3dca6.
badrishc
reviewed
Dec 4, 2024
badrishc
reviewed
Dec 4, 2024
badrishc
reviewed
Dec 4, 2024
badrishc
reviewed
Dec 5, 2024
badrishc
reviewed
Dec 5, 2024
2. Refactor continuewith to async/await pattern
badrishc
reviewed
Dec 5, 2024
…om:microsoft/garnet into users/padgupta/add_async_socket_processing
vazois
requested changes
Dec 17, 2024
vazois
requested changes
Dec 18, 2024
| } | ||
| } | ||
|
|
||
| void NetworkBufferProcessed(object sender, SocketAsyncEventArgs e) |
There was a problem hiding this comment.
Is this method necessary? Can we move the enclosed piece of code in the caller instead?
There was a problem hiding this comment.
yes, please revert this method and inline it as it was earlier
badrishc
reviewed
Dec 18, 2024
| @@ -144,22 +151,37 @@ void RecvEventArg_Completed(object sender, SocketAsyncEventArgs e) | |||
| { | |||
| // No more things to receive | |||
| Dispose(e); | |||
| break; | |||
| return; | |||
There was a problem hiding this comment.
Revert this back to break?
badrishc
reviewed
Dec 18, 2024
| e.SetBuffer(networkReceiveBuffer, networkBytesRead, networkReceiveBuffer.Length - networkBytesRead); | ||
| } while (!e.AcceptSocket.ReceiveAsync(e)); | ||
| var receiveTask = OnNetworkReceiveAsync(e.BytesTransferred); | ||
| if (!receiveTask.IsCompleted) |
There was a problem hiding this comment.
!IsCompletedSuccessfully is better than !IsCompleted because it excludes faulted and canceled tasks, allowing the await to properly capture and rethrow those exceptions.
badrishc
reviewed
Dec 18, 2024
| await receiveTask; | ||
| } | ||
| NetworkBufferProcessed(sender, e); | ||
| } |
There was a problem hiding this comment.
nit: while should be on same line as } to maintain parity with style on main:
do
{
} while (!e.AcceptSocket.ReceiveAsync(e));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Garnet's network processing in TLS mode happens by blocking the thread that receives the packet and it waits for TLS processing to complete. This leads to threadpool exhaustion and is an anti-pattern in general. It limits scalability where cores are limited as threads will get blocked and .NET will create more threads (where limit is not set). This makes things worst as memory footprint increases (~8MB per stack) and thread contention increases. We also convert Task to ValueTask for paths where async operation is already completed in general
BDN results for Network test added
BenchmarkDotNet v0.14.0, Windows 11 (10.0.26100.2605) (Hyper-V)
AMD EPYC 7763, 1 CPU, 16 logical and 8 physical cores
.NET SDK 9.0.100
[Host] : .NET 8.0.11 (8.0.1124.51707), X64 RyuJIT AVX2
.NET 8 : .NET 8.0.11 (8.0.1124.51707), X64 RyuJIT AVX2
Job=.NET 8 EnvironmentVariables=DOTNET_TieredPGO=0 Runtime=.NET 8.0
Server=True
Without changes
With Changes
Job=.NET 8 EnvironmentVariables=DOTNET_TieredPGO=0 Runtime=.NET 8.0
Server=True
Remaining BDN Results
BenchmarkMain.log
BenchmarkWithAsyncChanges.log