-
Notifications
You must be signed in to change notification settings - Fork 538
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Changes to Release pipeline to include GarnetServer nuget and other c…
…hanges to the process (#809) * First test run for GarnetServer in release pipeline * Disabled Zip files step * Disable the task copying zipped files * Debug message cleaned up and everything enabled EXCEPT for the final Garnet Release step and actual Push to Nuget.org * Added -p:PackageVersion=$(name) to release yml and removed <Version>1.0.38</Version> from GarnetServer.csproj * Trying nuget pack on Garnet Library * Trying PACKAGE_VERSION variable * Adding extracting version number from version.json * Trying to use Build.BuildNumber instead of pulling from version.json * Moved version.json to root (adjusted extract_version.ps1). Have debug codestill in too. * Updated to use Directory.Build.props * Cleaned up debug messages and have all version implemented. Still have Push to Nuget and Push to GH Release disabled. Also Garnet Library pack uses .nuspec instead of dotnet pack * Fixed GarnetServer to use GetVersion() to set the version based on the prefix in Directory.Build.props. * Fixed bug in GetVersion * Setting version variable which also set Build Name. * Move setting build number to first step * Fixed bug with setting version * Fixed bug as the set version had to be after check out. * Trying to set (build.updatebuildnumber) to version to see if it works in ADO pipeline output * Trying to build without setting variable called "version" and instead seeing if it works when the BuildNumber is updated * Trying Build.BuildNumber instead of the $version env var * Packing Microsoft.Garnet using DotNet Pack and also moved the shared Nuget meta data to Directory.Builds.props. * Remove Garnet.nuspec as it is not needed any more. * Removed Garnet.nuspec from sln * Add the dotnet pack line to release yml for the Garnet Library * Fixed issue in nuget pack Garnet Library * Left behind a hardcode path * Added --no-build --no-restore to the dotnet pack so doesn't rebuild * Removed Nuget install / authenticate and also trying to get README.md into library nuget package * Fixed README.md part of the nuget package * Trying to fix Readme package for Nuget * Debug code left in ... removed it * Works locally but not when ran in ADO. Trying to set WorkingDirectory to see if that helps. * Added SymbolPackageFormat=snupkg for the nuget package symbols * Missing Title tag in the Directory.Build.props * Set the version to 1.0.40 and enabled the GitHub Release and Nuget Push tasks. * Changing case of readme.md to README.md * All the semi minor changes (spacing etc) from the PR comments * Added Version.props as the single place to update version instead of Directory.Build.props. Push to GH Release and Push to Nuget ARE DISABLED for this check in to be able to test first * Trying to get .pdb out of nuget packages other than the symbols package * Another try at not having .pdb files in the nuget package * Tyring include symbols in the csproj and the exclude pdb in Directory.Build.props * some changes * update * Fixed GarnetServer to include the proper files in the Nuget package. Push to Nuget and Push to Github release are NOT enabled until we test through in actual pipeline * Set library to NOT have pdb in nupkg and have server set up to have pdbs in nupkg since it is a dotnet tool * Updated version to 41 and got the release pipeline all ready to merge where it WILL PUSH TO NUGET.ORG and create a GH Release. This release has no pdb files in the nupkg package and only Garnet.Host.pdb in the .snupkg file. * Changed from pdbs in .snupkg to embedding debug symbols into DLL. * One final test before setting it to be merged * Version bumped to 42. Create Git Hub Release is now ENABLED and the Push to Nuget.org is now ENABLED. * Moved IncludeSymbols and IncludeSource to Directory.Build.Props and set EmbedUntrackedSources to truefor Garnet.host * Put IncludeSymbols, IncludeSourceand DebutType into same PropertyGroup since they are closerly related --------- Co-authored-by: Badrish Chandramouli <[email protected]>
- Loading branch information
Showing
11 changed files
with
129 additions
and
144 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <#$f | ||
| .DESCRIPTION | ||
| This script pulls the version number from Version.props which is located in the root directory. | ||
| It then assigns the value to the BuildNumber which can be used in pipeline yml files | ||
| #> | ||
|
|
||
| $propsFile = Resolve-Path -Path "$PSScriptRoot/../../Version.props" | ||
| [xml]$xml = Get-Content -Path $propsFile | ||
| $version = $xml.Project.PropertyGroup.VersionPrefix | ||
| Write-Host "##vso[build.updatebuildnumber]$version" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,59 @@ | ||
| <Project> | ||
|
|
||
| <PropertyGroup Label="Targets"> | ||
| <PropertyGroup Label="Targets"> | ||
| <TargetFrameworks>net8.0</TargetFrameworks> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- Versioning property for builds and packages --> | ||
| <Import Project="Version.props" /> | ||
|
|
||
| <PropertyGroup Label="Configuration"> | ||
| <LangVersion>latest</LangVersion> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild> | ||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(TF_BUILD)' == 'true' or '$(GITHUB_ACTIONS)' == 'true'"> | ||
| <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- Embeds debug symbols in the DLLs instead of separate pdb files --> | ||
| <PropertyGroup> | ||
| <DebugType>embedded</DebugType> | ||
| <IncludeSymbols>false</IncludeSymbols> | ||
| <IncludeSource>false</IncludeSource> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <EmbeddedFiles Include="$(GeneratedAssemblyInfoFile)"/> | ||
| <EmbeddedFiles Include="$(TargetFrameworkMonikerAssemblyAttributesPath)"/> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Content Include="../../website/static/img/garnet-logo-diamond.png" Pack="true" Visible="false" PackagePath="/" /> | ||
| </ItemGroup> | ||
|
|
||
| <!-- Common properties for nuget packages --> | ||
| <PropertyGroup> | ||
| <Product>Garnet</Product> | ||
| <Authors>Microsoft</Authors> | ||
| <Company>Microsoft</Company> | ||
| <RepositoryType>git</RepositoryType> | ||
| <RepositoryUrl>https://github.com/microsoft/garnet.git</RepositoryUrl> | ||
| <PackageProjectUrl>https://microsoft.github.io/garnet</PackageProjectUrl> | ||
| <PackageLicenseExpression>MIT</PackageLicenseExpression> | ||
| <PackageRequireLicenseAcceptance>True</PackageRequireLicenseAcceptance> | ||
| <Description> | ||
| Garnet is a remote cache-store from Microsoft Research, that offers strong performance (throughput and latency), | ||
| scalability, storage, recovery, cluster sharding, key migration, and replication features. Garnet uses the Redis RESP wire | ||
| protocol and can work with existing Redis clients. | ||
| </Description> | ||
| <PackageIcon>garnet-logo-diamond.png</PackageIcon> | ||
| <PackageReleaseNotes>See https://github.com/microsoft/garnet for details.</PackageReleaseNotes> | ||
| <Copyright>© Microsoft Corporation. All rights reserved.</Copyright> | ||
| <language>en-US</language> | ||
| <PackageTags>Garnet key-value store cache dictionary hashtable concurrent persistent remote cluster Redis RESP</PackageTags> | ||
| </PropertyGroup> | ||
|
|
||
| </Project> |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <Project> | ||
| <!-- Versioning property for builds and packages --> | ||
| <PropertyGroup> | ||
| <VersionPrefix>1.0.42</VersionPrefix> | ||
| </PropertyGroup> | ||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.