Add the type of Intl.DurationFormat to the lib. #60646
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
I referred to the two links below, but lint does not work properly. Can I get help? -https://github.com/microsoft/TypeScript/blob/main/CONTRIBUTING.md#get-started |
|
Your CI is passing linting, so I'm not sure what you mean. The section you are looking for to fix tests is https://github.com/microsoft/TypeScript/blob/main/CONTRIBUTING.md#managing-the-baselines For formatting, run |
jakebailey
reviewed
Dec 8, 2024
| @@ -56,7 +56,7 @@ declare namespace Intl { | |||
| * | |||
| * [MDN](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Intl#Locale_negotiation). | |||
| */ | |||
| type RelativeTimeFormatLocaleMatcher = "lookup" | "best fit"; | |||
There was a problem hiding this comment.
This type must not be renamed, as that would be a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial type for prototype
Fixes #60608
This is a work in progress, so I'll release the draft when I'm done.