Improve isTypeParameterAtTopLevel
to handle substitution types and template literal types
#60643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches a surprising difference in the inference behavior in respect to return types:
The rule is that
T
has to appear in a top-level position in the return type for its literalness to be preserved. From the user's point of view ,it is intest2
's top-level position in the return type. But sinceT
in that truthy branch is seen as a substitution type for the compiler it fails to recognize it.