Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fuzz] Add fuzz testing for AdvancedPaste and new pipeline for onboarding OneFuzz #36329

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Dec 13, 2024

Summary of the Pull Request

Why we need add fuzz test?
This is a request from the SFI Wave 3, currently set as Priority 1.

In this PR:

  1. New Fuzz Tests Project: Created for AdvancedPaste using .NET 8-Windows. Initial testing will focus on JsonHelper.
    • Note: Since OneFuzz does not yet support .NET 9 code testing, this is a temporary solution. A .NET 8 project is used initially, linking the code through a file.
  2. Linking and Dependency Management: Connected JsonHelper file to the Fuzz Tests Project, minimizing dependencies by adding a mock Logger.
  3. New Pipeline: Introduced to onboard OneFuzz.

Testing Result:
The new pipeline is being tested using the CI pipeline.

the fuzz job result:
image

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

This comment has been minimized.

@lei9444 lei9444 marked this pull request as ready for review December 13, 2024 13:36
@lei9444 lei9444 requested a review from a team as a code owner December 13, 2024 13:36
@crutkas crutkas added In for .88 Don't merge - Hold for release Hold off on merging this PR, even if it's approved. Needs-Review This Pull Request awaits the review of a maintainer. labels Dec 13, 2024
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

.pipelines/v2/oneFuzz.yml Outdated Show resolved Hide resolved
.pipelines/v2/templates/job-fuzz.yml Outdated Show resolved Hide resolved
@crutkas crutkas added Good to Merge Good to merge after release and removed Needs-Review This Pull Request awaits the review of a maintainer. Good to Merge labels Dec 14, 2024
@yeelam-gordon yeelam-gordon self-requested a review December 16, 2024 03:40
Copy link

@yeelam-gordon yeelam-gordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for make it happens, I added minior comments so that others can refer to this project better for fuzzing.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

This comment has been minimized.

@yeelam-gordon yeelam-gordon self-requested a review December 17, 2024 07:49
@jaimecbernardo jaimecbernardo removed the Don't merge - Hold for release Hold off on merging this PR, even if it's approved. label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants