Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new pipeline using the latest webview2 from Edge Canary #36317

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

shuaiyuanxx
Copy link
Contributor

Summary of the Pull Request

Changes Introduced

This PR introduces a new parameter usingLatestWebView2 to control whether the latest WebView2 Canary version is used during testing and CI builds. The specific changes are as follows:

  1. job-test-project.yml
  • Added usingLatestWebView2 parameter of type boolean with a default value of false.
  • Included a PowerShell script to download and install the latest Microsoft Edge Canary version.
  • Added a registry modification script to enable the WebView2 Canary channel.
  1. pipeline-ci-build.yml
  • Added usingLatestWebView2 parameter of type boolean with a default value of false.
  • Passed the usingLatestWebView2 parameter in the stages section to use it during CI builds.

Purpose

The introduction of the usingLatestWebView2 parameter allows developers to opt-in to using the latest WebView2 Canary version during tests and CI builds. This helps in identifying and resolving issues related to the latest WebView2 version early, thereby improving the project's stability and compatibility.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

pipeline runs successfully.

@shuaiyuanxx shuaiyuanxx requested a review from a team as a code owner December 12, 2024 09:07
Signed-off-by: Shawn Yuan <[email protected]>

This comment has been minimized.

@crutkas crutkas added In for .88 Don't merge - Hold for release Hold off on merging this PR, even if it's approved. labels Dec 13, 2024
@crutkas
Copy link
Member

crutkas commented Dec 13, 2024

fixed spell check failure

@crutkas
Copy link
Member

crutkas commented Dec 13, 2024

is there someway to validate we're getting the canary version and the pipeline would fail if canary is in a bad spot?

@yeelam-gordon
Copy link

is there someway to validate we're getting the canary version and the pipeline would fail if canary is in a bad spot?
If there is no automation functional test related to Webview2 component, I think the answer is no.
We can see what automation we can add in near future.

@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Dec 13, 2024
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am leaving for the holidays on Monday 2024-12-16 and I will not be back until 2025-01-06.

If you address these comments before I am back, you may dismiss my review.

.pipelines/v2/templates/job-test-project.yml Outdated Show resolved Hide resolved
.pipelines/v2/templates/job-test-project.yml Outdated Show resolved Hide resolved
@DHowett
Copy link
Member

DHowett commented Dec 13, 2024

Oh! PR #36282 uses the word use instead of using. For consistency, you should stick with one version of that word! 🙂

Signed-off-by: Shawn Yuan <[email protected]>
@shuaiyuanxx
Copy link
Contributor Author

Oh! PR #36282 uses the word use instead of using. For consistency, you should stick with one version of that word! 🙂

Done

@shuaiyuanxx shuaiyuanxx reopened this Dec 16, 2024
@crutkas
Copy link
Member

crutkas commented Dec 16, 2024

per @DHowett statement, @shuaiyuanxx saying he addressed the feedback, i'm going to dismiss Dustin's review.

@crutkas crutkas dismissed DHowett’s stale review December 16, 2024 22:04

DHowett is on vacation, feedback was addressed

@crutkas
Copy link
Member

crutkas commented Dec 17, 2024

@yeelam-gordon my statement for failing was just to be sure we know everything works in the failure case for alerting

@crutkas crutkas added Good to Merge Good to merge after release and removed Needs-Review This Pull Request awaits the review of a maintainer. Good to Merge labels Dec 17, 2024
@Jay-o-Way Jay-o-Way added the Area-Build Issues pertaining to the build system, CI, infrastructure, meta label Dec 18, 2024
@jaimecbernardo jaimecbernardo removed the Don't merge - Hold for release Hold off on merging this PR, even if it's approved. label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Good to merge after release In for .88
Projects
Development

Successfully merging this pull request may close these issues.

6 participants