-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new pipeline using the latest webview2 from Edge Canary #36317
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
Signed-off-by: Shawn Yuan <[email protected]>
This comment has been minimized.
This comment has been minimized.
fixed spell check failure |
is there someway to validate we're getting the canary version and the pipeline would fail if canary is in a bad spot? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am leaving for the holidays on Monday 2024-12-16 and I will not be back until 2025-01-06.
If you address these comments before I am back, you may dismiss my review.
Oh! PR #36282 uses the word |
Signed-off-by: Shawn Yuan <[email protected]>
Done |
per @DHowett statement, @shuaiyuanxx saying he addressed the feedback, i'm going to dismiss Dustin's review. |
DHowett is on vacation, feedback was addressed
@yeelam-gordon my statement for failing was just to be sure we know everything works in the failure case for alerting |
Summary of the Pull Request
Changes Introduced
This PR introduces a new parameter
usingLatestWebView2
to control whether the latest WebView2 Canary version is used during testing and CI builds. The specific changes are as follows:usingLatestWebView2
parameter of type boolean with a default value of false.usingLatestWebView2
parameter of type boolean with a default value of false.usingLatestWebView2
parameter in the stages section to use it during CI builds.Purpose
The introduction of the
usingLatestWebView2
parameter allows developers to opt-in to using the latest WebView2 Canary version during tests and CI builds. This helps in identifying and resolving issues related to the latest WebView2 version early, thereby improving the project's stability and compatibility.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
pipeline runs successfully.