Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continued motion to move stuff out of root - solution.prop #36244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

crutkas
Copy link
Member

@crutkas crutkas commented Dec 6, 2024

Summary of the Pull Request

Moving solution.prop to src folder where other props are

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Dec 10, 2024
@crutkas
Copy link
Member Author

crutkas commented Dec 10, 2024

@Jay-o-Way. Why the thumbs down?

@jaimecbernardo jaimecbernardo added the Don't merge - Hold for release Hold off on merging this PR, even if it's approved. label Dec 11, 2024
@jaimecbernardo
Copy link
Collaborator

Hi, we've added the "Don't Merge" tag to the PR, since we're trying to keep the repo stable for the release and possible hotfix if necessary. Please don't merge the PR while the tag is still in here. This allows people to review the PR and approve with less fear that it'll get merged 😄

@jaimecbernardo jaimecbernardo removed the Don't merge - Hold for release Hold off on merging this PR, even if it's approved. label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In for .88 Needs-Review This Pull Request awaits the review of a maintainer.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants