[AOT compatible] Clean up some AOT build issue in FilePreviewCommon and MarkdownPreviewHandler

[moooyo]

Summary of the Pull Request

• Fix json serializer AOT issue.
• Especially, use AppContext.BaseDirectory to replace assembly.Location.

PR Checklist

• Closes: #xxx
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass

1. Manual test paseed in my local env.
2. I will use pipline artifact to do some test after pipline complete and paste the test results here.

• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

[moooyo]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[moooyo]

I encountered some build issue when I was trying to build installer locally. That's the reason why I need to wait for pipeline complete...
I followed the doc and installed the required package. But sesms that there's no icon.ico and PowerToysSetup-0.0.1-x64.msi exist in the Release folder.
Dose anyone know how to solve it? I've checked that the release folder doesn't have these files.

[jaimecbernardo]

Hi @moooyo , I usually build the installer to give it a test through these incantations in the "Developer Command Prompt for VS 2022`:

MSBuild -t:restore -p:RestorePackagesConfig=true /p:Platform="x64" /p:Configuration=Release
MSBuild -m .\PowerToys.sln /p:Configuration=Release /p:Platform="x64"
MSBuild -t:restore .\tools\BugReportTool\BugReportTool.sln -p:RestorePackagesConfig=true /p:Platform="x64" /p:Configuration=Release
MSBuild -m .\tools\BugReportTool\BugReportTool.sln /p:Configuration=Release /p:Platform="x64"
MSBuild -t:restore .\tools\WebcamReportTool\WebcamReportTool.sln -p:RestorePackagesConfig=true /p:Platform="x64" /p:Configuration=Release
MSBuild -m .\tools\WebcamReportTool\WebcamReportTool.sln /p:Configuration=Release /p:Platform="x64"
MSBuild -t:restore .\tools\StylesReportTool\StylesReportTool.sln -p:RestorePackagesConfig=true /p:Platform="x64" /p:Configuration=Release
MSBuild -m .\tools\StylesReportTool\StylesReportTool.sln /p:Configuration=Release /p:Platform="x64"
git clean -xfd  -e *exe -- .\installer\
MSBuild -t:restore .\installer\PowerToysSetup.sln -p:RestorePackagesConfig=true /p:Platform="x64" /p:Configuration=Release
MSBuild -m .\installer\PowerToysSetup.sln /t:PowerToysInstaller /p:Configuration=Release /p:Platform="x64"
MSBuild -m .\installer\PowerToysSetup.sln /t:PowerToysBootstrapper /p:Configuration=Release /p:Platform="x64"

Hope this helps.

[moooyo]

Hi @moooyo , I usually build the installer to give it a test through these incantations in the "Developer Command Prompt for VS 2022`:

MSBuild -t:restore -p:RestorePackagesConfig=true /p:Platform="x64" /p:Configuration=Release
MSBuild -m .\PowerToys.sln /p:Configuration=Release /p:Platform="x64"
MSBuild -t:restore .\tools\BugReportTool\BugReportTool.sln -p:RestorePackagesConfig=true /p:Platform="x64" /p:Configuration=Release
MSBuild -m .\tools\BugReportTool\BugReportTool.sln /p:Configuration=Release /p:Platform="x64"
MSBuild -t:restore .\tools\WebcamReportTool\WebcamReportTool.sln -p:RestorePackagesConfig=true /p:Platform="x64" /p:Configuration=Release
MSBuild -m .\tools\WebcamReportTool\WebcamReportTool.sln /p:Configuration=Release /p:Platform="x64"
MSBuild -t:restore .\tools\StylesReportTool\StylesReportTool.sln -p:RestorePackagesConfig=true /p:Platform="x64" /p:Configuration=Release
MSBuild -m .\tools\StylesReportTool\StylesReportTool.sln /p:Configuration=Release /p:Platform="x64"
git clean -xfd  -e *exe -- .\installer\
MSBuild -t:restore .\installer\PowerToysSetup.sln -p:RestorePackagesConfig=true /p:Platform="x64" /p:Configuration=Release
MSBuild -m .\installer\PowerToysSetup.sln /t:PowerToysInstaller /p:Configuration=Release /p:Platform="x64"
MSBuild -m .\installer\PowerToysSetup.sln /t:PowerToysBootstrapper /p:Configuration=Release /p:Platform="x64"

Hope this helps.

Thanks!!! It works.

[moooyo]

I've added a simple test here.

[moooyo]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[snickler]

LGTM

.

[moooyo]

Accept all suggestions. Thanks @snickler !

[moooyo]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jaimecbernardo]

Hi, we've added the "Don't Merge" tag to the PR, since we're trying to keep the repo stable for the release and possible hotfix if necessary. Please don't merge the PR while the tag is still in here. This allows people to review the PR and approve with less fear that it'll get merged 😄

[yeelam-gordon]

You may make decision to change it now, or in another PR.

[yeelam-gordon]

I remember I see this file twice on different location.
Looks like we need somewhere more centralized but not per project.

[snickler]

@yeelam-gordon each class implementing the JsonSerializerContext class has to be in a spot where each of the class types are available to it. There are many types that are in the Settings project, but some types that are only in the individual projects. This one though, would actually be a good one to be moved to a more centralized location.