Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process Restart Management with Error Handling #36159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

karurung
Copy link

The edited code shows error message.

Summary of the Pull Request

     Added error handling and error code display to `RmStartSession` and `RmRegisterResources` functions.

PR Checklist

  • [n/a] Closes: #xxx
  • [n/a] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • [n/a] Tests: Added/updated and all pass
  • [n/a] Localization: All end user facing strings can be localized
  • [n/a] Dev docs: Added/updated
  • [n/a] New binaries: Added on the required places
  • [n/a] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

        I didn't add any new functions, but this change makes displaying error messages possible.

Validation Steps Performed

          Not tested yet.

The edited code shows error message.
@htcfreek
Copy link
Collaborator

@karurung
Is there a specific reason why you add this?

@karurung
Copy link
Author

This change is not really necessary, but I think this change will help displaying error codes, makes troubleshooting easier for developers and users, if I understand this code correctly.

@karurung
Copy link
Author

karurung commented Nov 30, 2024

Also, the file name is RestartManagement, so I believe my code is helpful to show error types.

@jaimecbernardo
Copy link
Collaborator

Hi, Why is this file using stdout instead of the actual logging infrastructure we have in place?
What actual errors will this change help in debugging? Are there some specific utilities you are looking into debugging?

@karurung
Copy link
Author

karurung commented Dec 3, 2024

Hi, I'm new for this project, the reason why I used stdout because it quickly display error codes during development and testing. Especially, I think this helps debugging for RestartManager APIs fails, which making it easier to identify issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants