You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does simply make DuplicateService and HostsService to be a partial class. It makes the HostsUILib AOT compatibility and we can mark HostsUILib is AOT compatiability after merging this PR change.
PR Checklist
Closes: #xxx
Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
Tests: Added/updated and all pass
Localization: All end user facing strings can be localized
@moooyo I marked #36176 approved and good to merge in. I'm assuming that needs to go in, this will then adopt that in the csproj and this will be ready, correct?
@moooyo I marked #36176 approved and good to merge in. I'm assuming that needs to go in, this will then adopt that in the csproj and this will be ready, correct?
Sure. I think so. We can check-in csproj change in this PR after #36176 merged. It's ready to mark HostsUILib to AOT compatible. I've tested it manually.
Sorry for the confusion. I mean, we can refer Common.Dotnet.AotCompatibility.props (which merged in #36176) in the HostsUILib's csproj file in this PR.
Hi, we've added the "Don't Merge" tag to the PR, since we're trying to keep the repo stable for the release and possible hotfix if necessary. Please don't merge the PR while the tag is still in here. This allows people to review the PR and approve with less fear that it'll get merged 😄
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
crutkas
added
Needs-Review
jaimecbernardo
added
the
Don't merge - Hold for release
Summary of the Pull Request
This PR does simply make DuplicateService and HostsService to be a partial class. It makes the HostsUILib AOT compatibility and we can mark HostsUILib is AOT compatiability after merging this PR change.
PR Checklist
Detailed Description of the Pull Request / Additional comments
The target is make PowerToys AOT compatible. That's a big change. So, we will split it to more small work. This PR is one of the AOT compatible work.
Validation Steps Performed