Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New+ Update last modified date to now for all templates created #36133

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cgaarden
Copy link
Contributor

@cgaarden cgaarden commented Nov 27, 2024

Summary of the Pull Request

  • Implemented fix for 35391, as I do think that last modified should match created in this case to avoid confusion.
  • Update last modified time stamp to now for all files created.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Update last modified time stamp to now for all files created

Validation Steps Performed

  • Tested on Windows 10
  • Tested on Windows 11
  1. New+ from template where single file where the template last modified was "old"
  2. New+ from template where directory with a few files where last modified was "old" (and validated that newly created directory and all files and directories was updated)
  3. Checked that there aren't any spammy tracing (need to further investigate as it looks like we no more are logging number of templates)

@cgaarden cgaarden changed the title Update last modified date to now for all templates created New+ Update last modified date to now for all templates created Nov 28, 2024
@htcfreek
Copy link
Collaborator

htcfreek commented Dec 3, 2024

What about the folders? Does Windows Explorer calculates their time based on the content?

@cgaarden
Copy link
Contributor Author

cgaarden commented Dec 4, 2024

Fixed! Thank you @htcfreek, much appreciated!

@cgaarden cgaarden marked this pull request as ready for review December 15, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants